Ignore suggestions based on previously ignored #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marisks shouln't logEvents.Count be used instead of bufferSize in check of threshold as well? Here I mean: |
|
We are working on rewriting the whole logging logic for Suggestions. This PR will be out of date soon. |
|
How soon? It would be nice to avoid getting a lot of suggestions already ignored. |
|
Closing this issue, due to the fix was provided here: #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Now suggestions are not added if a matching ignore is found.
Also rewrote the buffering of 404 to allow logging if threshold has passed as well. Meaning the buffer can be less than buffersize before being processed. Seems logical to me but perhaps there's a reason for waiting to fill the buffersize always.